Refactor js #1077
Merged
Refactor js #1077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1077 +/- ##
=======================================
Coverage 84.29% 84.29%
=======================================
Files 24 24
Lines 1318 1318
Branches 178 178
=======================================
Hits 1111 1111
Misses 157 157
Partials 50 50Continue to review full report at Codecov.
|
Contributor
|
Please squash your commits. Thank you. |
Contributor
|
I think it would be great to drop the jQuery dependency! (Maybe the linked issue should be reopened.) Let me know if you need any help, I'd be happy to lend a hand wherever it could be used. |
Contributor
Author
done (btw, did you know that github can do this automatically? The merge button should give you the option to do a "squash merge" instead) |
Contributor
|
@xi I just surprised myself :) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to help refactoring the javascript code and potentially removing the jquery dependency. I know this has been discussed in #562 already. But since then, 4 years have passed and some new DOM APIs have become available.
As a first step I did some small changes to bring the code up to modern jquery standards.
Please let me know if you are interested in this work or if there is anything else frontend-related I could help with.